Fix: sort SKU variations #2367
Open
Fix: sort SKU variations #2367
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wender
requested review from
emersonlaurentino and
eduardoformiga
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Nice! Thank you for the PR.
Do you have a store so that we can validate this change with the version generated from the codesandbox?
Also, we need to validate this rule with FastStore team since are cases we should respect the catalog order.
Finally, the build is not passing. Can you take a look?
| ) | ||
|
|
||
| const isNumeric = (value) => { | ||
| return !isNaN(value - parseFloat(value)) |
There was a problem hiding this comment.
This looks confusing. Why do we need this to check if it is a number?
|
@wender Hello! Thanks for opening this PR. I noticed it was opened some time ago. For more context, was it related to a specific store issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Currently, the SKU variations are not sorted
How it works?
It now checks if the value is a number or string and sort it alphabetically or numerically ascendant
How to test it?
Open a PDP with any of the SKU variations, number or text
Starters Deploy Preview
References