Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix russian rules #621

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Fix russian rules #621

wants to merge 2 commits into from

Conversation

isabellafagioli
Copy link

What is the purpose of this pull request?

Changing the field number in the Russian rule because it was hidden, and it should not be.

What problem is this solving?

A client is using this rule and is getting an error because the field number (that does not appear) is empty.

How should this be manually tested?

Go to add new addresses and see if there's a field number for Russia.

Screenshots or example usage

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link
Contributor

vtex-io-ci-cd bot commented Oct 16, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant