Skip to content

Commit

Permalink
Merge pull request #4 from vtex/loc/15048
Browse files Browse the repository at this point in the history
Adjust cards/menu with new labels & add new document
  • Loading branch information
GeorgeLimaDev authored Jun 26, 2024
2 parents 0350023 + 5ff182a commit e31f174
Show file tree
Hide file tree
Showing 8 changed files with 319 additions and 83 deletions.
6 changes: 3 additions & 3 deletions content/internal.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ <h6 class="header-subtext" id="header-subtext">Use the right voice for the right
</li>
<li>
<a href="#">
<p class="item JSsection" id="translationMemories" onclick="expandItem(id)"><span
class="material-symbols-outlined" id="collapseTranslationMemories">expand_more</span>
Translation Memories</p>
<p class="item JSsection" id="namingGuidelines" onclick="expandItem(id)"><span
class="material-symbols-outlined" id="collapseL10nAndI18n">expand_more</span>
Localization & Internationalization</p>
</a>
</li>
<li>
Expand Down
40 changes: 20 additions & 20 deletions content/internal.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ function handleInternal() { //Determines which content should be displayed in th
document.getElementById("main-frame").src = "./loc_admin_review_logs/Admin String Standardization - PT/VTEXAdminstringstandardizationinPortuguese.html";
expandItem("reviewLogs");
}
else if (currentUrl.includes("translationMemories")) {
displayTranslationMemoriesHeader(); //Changes the header to match the selected section/card.
document.getElementById("main-frame").src = "./translation_memory/translation_memory.html";
expandItem("translationMemories");
else if (currentUrl.includes("namingGuidelines")) {
displayL10nAndI18nHeader(); //Changes the header to match the selected section/card.
document.getElementById("main-frame").src = "./localization_and_internationalization/naming_guidelines.html";
expandItem("namingGuidelines");
}
}

Expand All @@ -73,11 +73,11 @@ function displayReviewLogsHeader() { //Changes the header and subheader to match
headerSubtext.innerText = "Check out the linguistic evolution of UI strings towards a native and consistent experience.";
}

function displayTranslationMemoriesHeader() { //Changes the header and subheader to match the selected card/section.
function displayL10nAndI18nHeader() { //Changes the header and subheader to match the selected card/section.
let headerText = document.getElementById("header-text");
headerText.innerText = "Translation Memories";
headerText.innerText = "Localization & Internationalization";
let headerSubtext = document.getElementById("header-subtext");
headerSubtext.innerText = "Seen that phrase before? Dig through our translation memory to recover it, or to simply get inspiration if you’re writing in another language.";
headerSubtext.innerText = "Create a product that is ready for a global audience by following localization and internationalization best practices.";
}

function expandItem(id) { //Determines which menu subsection should be open on load depending on the selected card.
Expand All @@ -90,8 +90,8 @@ function expandItem(id) { //Determines which menu subsection should be open on l
else if (id == "glossaries") {
expandGlossaries();
}
else if (id == "translationMemories") {
expandTranslationMemories()
else if (id == "namingGuidelines") {
expandL10nAndI18nMemories()
}
}

Expand All @@ -104,7 +104,7 @@ function expandStyleGuides() {
collapseStyleGuides();
} else {
collapseGlossaries();
collapseTranslationMemories();
collapseL10nAndI18n();
collapseReviewLogs();

icon.textContent = "expand_less";
Expand Down Expand Up @@ -190,7 +190,7 @@ function expandGlossaries() {
collapseGlossaries();
} else {
collapseStyleGuides();
collapseTranslationMemories();
collapseL10nAndI18n();
collapseReviewLogs();
button.textContent = "expand_less";
list = document.createElement("ul");
Expand Down Expand Up @@ -246,13 +246,13 @@ function collapseGlossaries() {
}
}

function expandTranslationMemories() {
let item = document.getElementById("translationMemories");
function expandL10nAndI18nMemories() {
let item = document.getElementById("namingGuidelines");
let list = item.querySelector("ul");
let button = document.querySelector("#collapseTranslationMemories");
let button = document.querySelector("#collapseL10nAndI18n");

if (list) {
collapseTranslationMemories(); // Call the new collapseTranslationMemories function
collapseL10nAndI18n(); // Call the new collapseTranslationMemories function
} else {
collapseStyleGuides();
collapseGlossaries();
Expand All @@ -261,7 +261,7 @@ function expandTranslationMemories() {
list = document.createElement("ul");

let items = [
{ id: "translationMemories", text: "Localization", link: "./internal.html?id=translationMemories" }
{ id: "namingGuidelines", text: "Naming Guidelines", link: "./internal.html?id=namingGuidelines" }
];

const currentPageHref = window.location.href;
Expand Down Expand Up @@ -300,10 +300,10 @@ function expandTranslationMemories() {
}
}

function collapseTranslationMemories() {
let item = document.getElementById("translationMemories");
function collapseL10nAndI18n() {
let item = document.getElementById("namingGuidelines");
let list = item.querySelector("ul");
let button = document.querySelector("#collapseTranslationMemories");
let button = document.querySelector("#collapseL10nAndI18n");

if (list) {
item.removeChild(list);
Expand All @@ -321,7 +321,7 @@ function expandReviewLogs() {
} else {
collapseStyleGuides();
collapseGlossaries();
collapseTranslationMemories();
collapseL10nAndI18n();
button.textContent = "expand_less";
list = document.createElement("ul");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,25 +207,25 @@ <h3 class="intro-content" id="lexical-preferences">Lexical preferences</h3>
<li class="bullet">“Complement” as an address field, which is a false cognate from PT, was changed to <span class="bold-text">additional information</span>.</li>
</ul>
</div>
<aside>
<nav class="aside-content">
<p class="content">CONTENT</p>
<ul class="aside-list">
<li class="selected">
<a class="aside-item" href="#introduction">Introduction</a>
</li>
<li class="false">
<a class="aside-item" href="#capitalization">Capitalization</a>
</li>
<li class="false">
<a class="aside-item" href="#grammar-forms">Grammar forms</a>
</li>
<li class="false">
<a class="aside-item" href="#lexical-preferences">Lexical preferences</a>
</li>
</ul>
</nav>
</aside>
</div>
<aside>
<nav class="aside-content">
<p class="content">CONTENT</p>
<ul class="aside-list">
<li class="selected">
<a class="aside-item" href="#introduction">Introduction</a>
</li>
<li class="false">
<a class="aside-item" href="#capitalization">Capitalization</a>
</li>
<li class="false">
<a class="aside-item" href="#grammar-forms">Grammar forms</a>
</li>
<li class="false">
<a class="aside-item" href="#lexical-preferences">Lexical preferences</a>
</li>
</ul>
</nav>
</aside>
</body>
</html>
Loading

0 comments on commit e31f174

Please sign in to comment.