Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes to dependencies, tests and code to be able to run tests #479

Open
wants to merge 1 commit into
base: v1.x
Choose a base branch
from

Conversation

cvarela-usesi
Copy link

What problem is this solving?

When working with an app forked from this main repo, I was unable to run tests from root directory, and when ran from node directory, there were several failed tests.

I also was unable to run lint from there.

With the changes made, now both lint and tests can be run with yarn

How should this be manually tested?

This can be manually tested this way from root (please make sure you have this version for yarn: v1.22.10):

yarn test

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Tests passing:
Screenshot 2024-08-22 at 4 05 25 PM

Lint running and detecting warnings and errors:
Screenshot 2024-08-22 at 4 08 59 PM

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
✔️ Technical improvements

Notes

Copy link

vtex-io-ci-cd bot commented Aug 22, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant