Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change datatype of listen.? parameters from String[1] to Array[String[1]] #621

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kBite
Copy link

@kBite kBite commented Apr 28, 2021

Follow-up on #611 implementing listen.? parameters as arrays instead of strings.

@kBite kBite requested a review from bastelfreak April 28, 2021 21:07
@kBite kBite marked this pull request as draft April 28, 2021 21:07
manifests/fpm/pool.pp Outdated Show resolved Hide resolved
@@ -186,6 +196,16 @@
default => $php::fpm::package,
}

# 'php-fpm' expects a comma separated list of user names
unless $listen_acl_users.empty {
$real_listen_acl_users = join(flatten($listen_acl_users).unique, ",")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$real_listen_acl_users = join(flatten($listen_acl_users).unique, ",")
$real_listen_acl_users = join(flatten($listen_acl_users).unique, ',')


# 'php-fpm' expects a comma separated list of group names
unless $listen_acl_groups.empty {
$real_listen_acl_groups = join(flatten($listen_acl_groups).unique, ",")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$real_listen_acl_groups = join(flatten($listen_acl_groups).unique, ",")
$real_listen_acl_groups = join(flatten($listen_acl_groups).unique, ',')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise puppet-lint complains :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants