-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beaker acceptance test : add idempotency check #225
base: master
Are you sure you want to change the base?
Conversation
b4f61bf
to
34172f7
Compare
* add idempotency check * rework because fail2ban::config and fail2ban::service are privates * renaming accordingly with name of tested class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with in-lining the manifest instead of using an example file although I do generally prefer using examples. The outdenting is kind of odd and should be fixed.
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-EOS | ||
class { 'fail2ban': } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be indented instead of outdented. I'm surprised that rubocop didn't warn on this...
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-EOS | ||
class { 'fail2ban': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with outdenting. This would also be better as an example/*.pp
so that it is linted.
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-EOS | ||
$_config_file_template = $facts['os']['family'] ? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with outdenting. This would also be better as an example/*.pp
so that it is linted.
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-EOS | ||
$_config_file_template = $facts['os']['family'] ? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with outdenting. This would also be better as an example/*.pp
so that it is linted.
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-EOS | ||
$_config_file_template = $facts['os']['family'] ? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with outdenting. This would also be better as an example/*.pp
so that it is linted.
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-EOS | ||
$_config_file_template = $facts['os']['family'] ? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with outdenting. This would also be better as an example/*.pp
so that it is linted.
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-EOS | ||
class { 'fail2ban': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with outdenting. This would also be better as an example/*.pp
so that it is linted.
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-EOS | ||
class { 'fail2ban': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with outdenting. This would also be better as an example/*.pp
so that it is linted.
This PR also:
fail2ban::config
andfail2ban::service
are privatesPull Request (PR) description
This Pull Request (PR) fixes the following issues