(maint) Update Gemfile and README for Ruby 2.5/2.4 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was not possible to bundle install on Ruby 2.5 with Puppet 5 on Windows due to FFI restrictions. This commit updates the Gemfile to use the appropriate default version of Puppet, based on the Ruby version ActiveSupport (Which is used by github log generator) v6.x requires Ruby 2.5. This commit adds a per-ruby version requirement for activesupport which will allow it to be bundled correctly for Ruby 2.5 and 2.4.
Many of the testing frameworks are not supported on Windows. This commit updates the README to explain that even though the project can be bundle installed correctly, the tests cannot be run, until such time as the tests are modified: - Expect is a bash only utility - Aruba is not supported on Windows cucumber/aruba#661
glennsarti
force-pushed
the
update-gemfile
branch
from
e76841e
to
aceb4a1
Compare
|
thanks for the PR @glennsarti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to bundle install on Ruby 2.5 with Puppet 5 on
Windows due to FFI restrictions. This commit updates the Gemfile to use the
appropriate default version of Puppet, based on the Ruby version
ActiveSupport (Which is used by github log generator) v6.x requires Ruby 2.5.
This commit adds a per-ruby version requirement for activesupport which will
allow it to be bundled correctly for Ruby 2.5 and 2.4.
Many of the testing frameworks are not supported on Windows. This commit
updates the README to explain that even though the project can be bundle
installed correctly, the tests cannot be run, until such time as the tests
are modified:
Note this PR also removes some trailing whitespace in the readme.