Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spaces in CMake files and pass Release explicitly when building from Dockerfile #44

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Use spaces in CMake files and pass Release explicitly when building from Dockerfile #44

merged 2 commits into from
Jul 12, 2024

Conversation

felipecrv
Copy link
Contributor

No description provided.

@felipecrv
Copy link
Contributor Author

I'm giving up on what I was trying to do with #43. CMake is hard. But I still want to push these small changes.

prmoore77
prmoore77 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@prmoore77 prmoore77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prmoore77 prmoore77 merged commit 9e08958 into main Jul 12, 2024
7 checks passed
@prmoore77 prmoore77 deleted the explicit_release_mode branch July 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prmoore77 prmoore77 prmoore77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipecrv @prmoore77