Skip to content

Commit

Permalink
Merge pull request #130 from voltrondata-labs/edward/hotfix/tpch-outp…
Browse files Browse the repository at this point in the history
…ut-param

Handle missing `output` param in tpc_h
  • Loading branch information
alistaire47 authored Feb 2, 2023
2 parents cd0592f + 6e93bf8 commit e1761b5
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion R/bm-tpc-h.R
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,11 @@ tpc_h <- Benchmark("tpch",
tags_fun = function(params) {
# for consistency with runs through voltrondata-labs/benchmarks
params$query_id <- sprintf("TPCH-%02d", params$query_id)
if (params$output == "data_frame") {
# TODO / NOTE: `params$output` may be NULL if not specified in a call to
# `run_one()` as voltrondata-labs/benchmarks does.
# [arrowbench#129](https://github.com/voltrondata-labs/arrowbench/issues/129)
# will fix this, at which point the first condition here should be removed.
if (!is.null(params$output) && params$output == "data_frame") {
params$output <- NULL
}
params
Expand Down

0 comments on commit e1761b5

Please sign in to comment.