Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests to use UBOs #9195

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Convert tests to use UBOs #9195

wants to merge 11 commits into from
+210 −153

Conversation

felixpalmer
Copy link
Collaborator

Remove remaining instances of setUniforms in tests

Change List

  • Port hexbin & project spec tests, adding UBOs to replace individual uniforms
  • Export ProjectProps type
  • Add typing
  • Rename & tidy to match new conventions

@coveralls
Copy link

Coverage Status

coverage: 91.639%. remained the same
when pulling ac23302 on felix/test-ubos
into 2e9d6dc on master.

ibgreen
ibgreen approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @coveralls @ibgreen