Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add d3-dsv library to mask-extension example's dependencies #9194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willemarcel
Copy link

Background

It was missing to install d3-dsv library in the mask-extension example. The example code doesn't run without it.

Change List

  • Include d3-dsv in the dependencies list.

@@ -14,6 +14,7 @@
"@material-ui/icons": "^4.9.1",
"@types/react": "^18.0.0",
"@types/react-dom": "^18.0.0",
"d3-dsv": "^3.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine for me without this. This module is not mentioned anywhere in the code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this error when I try to run it without installing d3-dsv

examples/website/mask-extension on  master [!] 
❯ yarn start
yarn run v1.22.11
$ vite --open

  VITE v4.5.5  ready in 350 ms

  ➜  Local:   http://127.0.0.1:5173/
  ➜  Network: use --host to expose
  ➜  press h to show help
✘ [ERROR] Could not resolve "d3-dsv"

    node_modules/@loaders.gl/csv/dist/lib/encoders/encode-csv.js:6:30:
      6 │ import { csvFormatRows } from 'd3-dsv';
        ╵                               ~~~~~~~~

  You can mark the path "d3-dsv" as external to exclude it from the bundle, which will remove this
  error.

/Users/wille/projects/deck.gl/examples/website/mask-extension/node_modules/esbuild/lib/main.js:1649
  let error = new Error(`${text}${summary}`);
              ^

Error: Build failed with 1 error:
node_modules/@loaders.gl/csv/dist/lib/encoders/encode-csv.js:6:30: ERROR: Could not resolve "d3-dsv"
    at failureErrorWithLog (/Users/wille/projects/deck.gl/examples/website/mask-extension/node_modules/esbuild/lib/main.js:1649:15)
    at /Users/wille/projects/deck.gl/examples/website/mask-extension/node_modules/esbuild/lib/main.js:1058:25
    at /Users/wille/projects/deck.gl/examples/website/mask-extension/node_modules/esbuild/lib/main.js:1525:9
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  errors: [
    {
      detail: undefined,
      id: '',
      location: {
        column: 30,
        file: 'node_modules/@loaders.gl/csv/dist/lib/encoders/encode-csv.js',
        length: 8,
        line: 6,
        lineText: "import { csvFormatRows } from 'd3-dsv';",
        namespace: '',
        suggestion: ''
      },
      notes: [
        {
          location: null,
          text: 'You can mark the path "d3-dsv" as external to exclude it from the bundle, which will remove this error.'
        }
      ],
      pluginName: '',
      text: 'Could not resolve "d3-dsv"'
    }
  ],
  warnings: []
}
error Command failed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants