chore(graph-layers): Restore pack-images script #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
changed the title
ibgreen
approved these changes
Apr 15, 2024
donmccurdy
force-pushed
the
donmccurdy/chore-test-naming
branch
from
006ba06
to
267fc7b
Compare
donmccurdy
force-pushed
the
chore/graph-layers-pack-markers-cleanup
branch
from
ae61618
to
c6d9d65
Compare
|
Merging for now, but maybe the top-level |
|
I was thinking that a There are probably also layers in editable-layers module that are quite generic. They could for instance be moved to the layers module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graph-layers module uses a script to generate the marker image spritesheet, which needed fixes since the repo has been migrated to TypeScript. I've also fixed the ESLint and TSC warnings for the script in the process. The get-pixels / save-pixels packages have been unmaintained for a few years now, so I've replaced both with
ndarray-pixels. (Disclaimer: I wrote 'ndarray-pixels' based on a combination of the older two).As a side effect of using async/await, markers in the sprite sheet are now sorted alphabetically.