Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): New react module #50

Merged
merged 9 commits into from
Apr 12, 2024
Merged

feat(react): New react module #50

merged 9 commits into from
Apr 12, 2024

Conversation

ibgreen
Copy link
Contributor

@ibgreen ibgreen commented Apr 11, 2024

See #38 (added new tasks at bottom)

  • Move generic react functionality out of the specialized modules and into a generic react module.
  • Move overlays and EditorModal to the generic react module
  • Goal is to eventually remove the specific helpers, if feaible.

@ibgreen ibgreen requested a review from donmccurdy April 11, 2024 21:30
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning all this up! Unfortunately a RegExp may have gone astray, several broken URLs. 😅

A flagged a few in comments below, but there are others in the PR.

dev-docs/RFCs/editable-layers/generic-edit-mode.md Outdated Show resolved Hide resolved
dev-docs/RFCs/editable-layers/generic-edit-mode.md Outdated Show resolved Hide resolved
Comment on lines +129 to +132
- `@@deck.gl-community/editable-layers/layers`
- depends on `@@deck.gl-community/editable-layers/edit-modes` and `deck.gl`
- contains `EditableGeoJsonLayer`, a deck.gl `CompositeLayer`
- Other modules are unaffected (e.g. `@nebula.gl/overlays`)
- Other modules are unaffected (e.g. `@@deck.gl-community/editable-layers/overlays`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should restore these RFCs from the original nebula repo, or remove them.

dev-docs/RFCs/editable-layers/react-map-gl-draw.md Outdated Show resolved Hide resolved
dev-docs/RFCs/editable-layers/react-map-gl-draw.md Outdated Show resolved Hide resolved
@ibgreen ibgreen merged commit 4878c85 into master Apr 12, 2024
1 check passed
@ibgreen ibgreen deleted the ib/react-module branch April 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants