-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): New react module #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning all this up! Unfortunately a RegExp may have gone astray, several broken URLs. 😅
A flagged a few in comments below, but there are others in the PR.
- `@@deck.gl-community/editable-layers/layers` | ||
- depends on `@@deck.gl-community/editable-layers/edit-modes` and `deck.gl` | ||
- contains `EditableGeoJsonLayer`, a deck.gl `CompositeLayer` | ||
- Other modules are unaffected (e.g. `@nebula.gl/overlays`) | ||
- Other modules are unaffected (e.g. `@@deck.gl-community/editable-layers/overlays`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should restore these RFCs from the original nebula repo, or remove them.
Co-authored-by: Don McCurdy <[email protected]>
49276f3
to
7a67e04
Compare
See #38 (added new tasks at bottom)