Add Leaflet module #138
Merged
Add Leaflet module #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakjan
force-pushed
the
leaflet
branch
2 times, most recently
from
c111cbc
to
190e199
Compare
ibgreen
approved these changes
Sep 14, 2024
| import 'leaflet/dist/leaflet.css'; | ||
|
|
||
| // source: Natural Earth http://www.naturalearthdata.com/ via geojson.xyz | ||
| const AIR_PORTS = |
There was a problem hiding this comment.
Suggested change
| const AIR_PORTS = | |
| const AIRPORTS_URL = |
| return this._deck.pickObjects(opts); | ||
| } | ||
|
|
||
| #getMap(): L.Map & {_animatingZoom: boolean; _getMapPanePos: () => L.Point} { |
There was a problem hiding this comment.
Nit: are these private declarations? We usually use the typescript private keyword and a leading underscore
| @@ -12,6 +12,7 @@ | |||
| }, | |||
| "type": "module", | |||
| "workspaces": [ | |||
| "examples/*", | |||
There was a problem hiding this comment.
Might be good to do this and the bing maps fix in separate PRs. This one in particular has caused some issues in the past. Make sure you can build the website. May have to revert if it messes up publishing.
| @@ -0,0 +1,12 @@ | |||
| // deck.gl-community | |||
There was a problem hiding this comment.
Fine, though not super excited about files called index... maybe we could name it after the tests inside?
|
@zakjan Feel free to merge whenever you are ready, or let me know if you need me to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.