-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): Remove transient dependencies from direct dependencies. #116
Conversation
I just saw, that the code actually imports stuff from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cg-sat Thanks for the PR. Can you also do a search for "react" dependencies across the repo and update across the board. In particular, can you make a pass on the examples directory?
As you can see in the log, you need to also commit the updated yarn.lock file when changing dependencies. Otherwise CI will reject the PR. |
@cg-sat, looks like we have a merge conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to ^18.2.0. Also updated to examples, that were still requesting react 16.
Perfect, will merge as soon as clean
Fixing it just now. |
Proposal 1 for #114
@ibgreen I'm not familiar with the projects' policy how to maintain transient dependencies. If proposal 2 is desired, I can change the PR accordingly.