Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): Remove transient dependencies from direct dependencies. #116

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

cg-sat
Copy link
Contributor

@cg-sat cg-sat commented Aug 2, 2024

Proposal 1 for #114
@ibgreen I'm not familiar with the projects' policy how to maintain transient dependencies. If proposal 2 is desired, I can change the PR accordingly.

@cg-sat
Copy link
Contributor Author

cg-sat commented Aug 2, 2024

I just saw, that the code actually imports stuff from styled-components and react. This means, that these two packages are not only transient dependencies but direct dependencies. This means they should also be made explicit.

Copy link
Contributor

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cg-sat Thanks for the PR. Can you also do a search for "react" dependencies across the repo and update across the board. In particular, can you make a pass on the examples directory?

modules/react/package.json Outdated Show resolved Hide resolved
@ibgreen
Copy link
Contributor

ibgreen commented Aug 2, 2024

As you can see in the log, you need to also commit the updated yarn.lock file when changing dependencies. Otherwise CI will reject the PR.

@ibgreen
Copy link
Contributor

ibgreen commented Aug 5, 2024

@cg-sat, looks like we have a merge conflict.

Copy link
Contributor

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to ^18.2.0. Also updated to examples, that were still requesting react 16.

Perfect, will merge as soon as clean

@cg-sat
Copy link
Contributor Author

cg-sat commented Aug 5, 2024

@cg-sat, looks like we have a merge conflict.

Fixing it just now.

@ibgreen ibgreen merged commit daf6cba into visgl:master Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants