Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unbreak publishing #126

Closed
8 tasks done
ibgreen opened this issue Aug 5, 2024 · 5 comments
Closed
8 tasks done

[Bug] Unbreak publishing #126

ibgreen opened this issue Aug 5, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ibgreen
Copy link
Contributor

ibgreen commented Aug 5, 2024

Module

  • deck.gl-community/arrow-layers
  • deck.gl-community/bing-maps
  • deck.gl-community/editable-layers
  • deck.gl-community/experimental
  • deck.gl-community/graph-layers
  • deck.gl-community/layers
  • deck.gl-community/react
  • deck.gl-community/react-graph-layer

Description

yarn run publish-prod does not actually publish anything

Expected Behavior

No response

Steps to Reproduce

yarn run publish-prod

Environment

  • Framework version: deck.gl-community@9
  • Browser:
  • OS:

Logs

No response

@ibgreen
Copy link
Contributor Author

ibgreen commented Aug 5, 2024

yarn run publish-prod just terminates after / in the tests. If the expectation is that the actual publish would happen through a github action,

  1. that action is not in place
  2. it would be nice with a message in the console indicating that this is what is happening.

image

@Pessimistress
Copy link
Contributor

Probably because there's no packages defined in lerna.json.

@ibgreen
Copy link
Contributor Author

ibgreen commented Aug 5, 2024

OK will add. Strangely it did however publish fine before with this lerna.json

image

@ibgreen
Copy link
Contributor Author

ibgreen commented Aug 5, 2024

Probably because there's no packages defined in lerna.json

Tried adding modules (#127).
But yarn run publish-prod is still a silent quitter.

@donmccurdy
Copy link
Collaborator

lerna.json#packages is optional in newer Lerna versions, and defaults to package.json#workspaces. Assuming that we do want Lerna to manage all of the workspaces, perhaps we want to remove the requirement of having lerna.json#packages eventually.

@ibgreen ibgreen closed this as completed Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants