-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module editable-layers has implicit dependency to layers #112
Labels
bug
Something isn't working
Comments
@cg-sat Thanks for reporting. Yes, that sounds reasonable. I believe a peerDependency would follow the conventions in deck.gl etc. Are you able to put up a PR to help speed things up? |
cg-sat
added a commit
to cg-sat/deck.gl-community
that referenced
this issue
Aug 2, 2024
ibgreen
pushed a commit
that referenced
this issue
Aug 5, 2024
Landed, pending #126 |
Published in v9.0.3, sorry for the long delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The module editable-layers has no explicit dependency to module layers: https://github.com/visgl/deck.gl-community/blob/master/modules/editable-layers/package.json
In fact the segments-layer is importing the layers module:
deck.gl-community/modules/editable-layers/src/lib/layers/segments-layer.ts
Line 9 in 646f832
This causes a build failure for any project, that only imports
@deck.gl-community/editable-layers
, but not@deck.gl-community/layers
. The workaround is to also import@deck.gl-community/layers
, but this implicit dependency should be made explicit by defining layers as peerDepdendency for editable-layers.The text was updated successfully, but these errors were encountered: