Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module editable-layers has implicit dependency to layers #112

Closed
cg-sat opened this issue Aug 1, 2024 · 4 comments · Fixed by #115
Closed

Module editable-layers has implicit dependency to layers #112

cg-sat opened this issue Aug 1, 2024 · 4 comments · Fixed by #115
Labels
bug Something isn't working

Comments

@cg-sat
Copy link
Contributor

cg-sat commented Aug 1, 2024

The module editable-layers has no explicit dependency to module layers: https://github.com/visgl/deck.gl-community/blob/master/modules/editable-layers/package.json

In fact the segments-layer is importing the layers module:

import {PathMarkerLayer} from '@deck.gl-community/layers';

This causes a build failure for any project, that only imports @deck.gl-community/editable-layers, but not @deck.gl-community/layers. The workaround is to also import @deck.gl-community/layers, but this implicit dependency should be made explicit by defining layers as peerDepdendency for editable-layers.

@ibgreen ibgreen added the bug Something isn't working label Aug 1, 2024
@ibgreen
Copy link
Contributor

ibgreen commented Aug 1, 2024

this implicit dependency should be made explicit by defining layers as peerDepdendency for editable-layers.

@cg-sat Thanks for reporting. Yes, that sounds reasonable. I believe a peerDependency would follow the conventions in deck.gl etc.

Are you able to put up a PR to help speed things up?

@cg-sat
Copy link
Contributor Author

cg-sat commented Aug 2, 2024

@ibgreen I cloned the repo and made the necessary changes in package.json of editable-layers module. While testing the correct package resolving, npm uncovered issue #114

A PR for this issue and for #114 will come shortly.

@ibgreen
Copy link
Contributor

ibgreen commented Aug 5, 2024

Landed, pending #126

@ibgreen
Copy link
Contributor

ibgreen commented Aug 25, 2024

Published in v9.0.3, sorry for the long delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants