Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for async host functions. #433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow for async host functions. #433

wants to merge 1 commit into from

Conversation

monkpow
Copy link
Collaborator

@monkpow monkpow commented Sep 25, 2019

@connorwhite huh, now these are broken out, I see we're missing test for these cases. I'll try to pick them up in the next day or so, or if you want to add tests I'll accept the commit then. Thanks!

@srinivasrk
Copy link

Hi, first off thanks for all your help. Is this PR merged into master? Is there no way to get async host resolution for now?

@devalexqt
Copy link

TypeError: Cannot read property 'request' of undefined
node_modules\express-http-proxy\app\steps\sendProxyRequest.js:13:51

@mitcns
Copy link

mitcns commented Sep 3, 2020

I met the same problem,TypeError, when I wanna use proxy to change req headers,this is the detail infos:
TypeError: Cannot read property 'request' of undefined
at /node_modules/_express-http-proxy@1.6.2@express-http-proxy/app/steps/sendProxyRequest.js:13:51
at new Promise ()
at sendProxyRequest (/node_modules/_express-http-proxy@1.6.2@express-http-proxy/app/steps/sendProxyRequest.js:11:10)
at process._tickCallback (internal/process/next_tick.js:68:7)

and check the console-term, it shows:
node_modules/send/index.js:1038
return typeof res.headersSent !== 'boolean'
^

TypeError: Cannot read property 'headersSent' of undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants