feat: parse mp4protection ContentProtection tags #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 94.68% 93.61% -1.07%
==========================================
Files 19 19
Lines 846 846
Branches 258 258
==========================================
- Hits 801 792 -9
- Misses 45 54 +9 ☔ View full report in Codecov by Sentry. |
misteroneill
approved these changes
Dec 8, 2023
dzianis-dashkevich
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an effort to enhance our HDCP handling in DASH we need to parse ContentProtection tags with the scheme
urn:mpeg:dash:mp4protection:2011. These tags when defined with theurn:mpeg:cenc:2013namespace contain acenc:default_KIDattribute that we can use to determine from the MediaKeySession, which playlists we have a usable license for.See: https://dashif-documents.azurewebsites.net/Guidelines-Security/master/Guidelines-Security.html#CPS-default_KID
or
Reference: ISO_IEC 23009-1_2022 section 5.8.5.2
Changes
urn:mpeg:dash:mp4protection:2011schemeId to the keySystems map so we parse ContentProtection tags with that scheme.