-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse content steering info #174
Conversation
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 94.58% 94.66% +0.07%
==========================================
Files 19 19
Lines 812 824 +12
Branches 247 251 +4
==========================================
+ Hits 768 780 +12
Misses 44 44
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work! +1 after warn instead of error on multiple <ContentSteering>
tags.
LGTM |
Feature
Add support for parsing
<ContentSteering>
tags, as well as content (serverURL
), thedefaultServiceLocation
,proxyServerUrl
, andqueryBeforeStart
attributes associated to that tag.This also adds support for
<BaseURL
tag properties to be included in our parsing of playlists, but specifically for our case, we ensure theserviceLocation
property is passed when it exists on a BaseURL tag.Changes
contentSteering
property on the parsed output containing the content of the tag asserverURL
, as well as the other properties on the tag.serviceLocation
property in theattributes
object in playlist items.<BaseURL>
to be passed into theattributes
object in playlist items.eventHandler
option that will handle events (to be replaced with stream parsing).References
https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#section-4.4.6.6