Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add service locator #26

Merged
merged 2 commits into from
Sep 24, 2024
Merged

feat: add service locator #26

merged 2 commits into from
Sep 24, 2024

Conversation

dzianis-dashkevich
Copy link
Collaborator

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (Chrome, Firefox, Safari, Edge) (if applicable)
  • Unit Tests updated or fixed (if applicable)
  • Docs/guides updated (if applicable)

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for videojsdev ready!

Name Link
🔨 Latest commit 5133910
🔍 Latest deploy log https://app.netlify.com/sites/videojsdev/deploys/66f3341325369b000860c065
😎 Deploy Preview https://deploy-preview-26--videojsdev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 94.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.36%. Comparing base (4558ca0) to head (5133910).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/playback/src/lib/player.ts 83.33% 2 Missing ⚠️
...kages/playback/src/lib/pipelines/mse/mseManager.ts 50.00% 1 Missing ⚠️
packages/playback/src/lib/serviceLocator.ts 97.82% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   62.01%   62.36%   +0.34%     
==========================================
  Files          79       81       +2     
  Lines        3625     3664      +39     
  Branches      443      450       +7     
==========================================
+ Hits         2248     2285      +37     
- Misses       1373     1375       +2     
  Partials        4        4              
Flag Coverage Δ
dash-parser 62.36% <94.66%> (+0.34%) ⬆️
hls-parser 62.36% <94.66%> (+0.34%) ⬆️
playback 62.36% <94.66%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzianis-dashkevich dzianis-dashkevich merged commit a9b5047 into main Sep 24, 2024
9 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the service-locator branch September 24, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant