-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyinstaller branch rebase and fbs removal #238
base: main
Are you sure you want to change the base?
Conversation
fbs was holding back the code from using modern versions of python, qt, and everything else. Remove fsb and update everything. * Remove fbs from spec * update to python 3.12 * update all dependencies to latest minor releases * update to latest version of pyinstaller * re-implement part of fbs context object to minimize refactoring * update Vial.spec to have all options necessary to run
721338d
to
0794bcc
Compare
0794bcc
to
9d4067d
Compare
Anecdotally, this seems to work on Linux for me. The Vial window opens, I can change key mappings on the keyboard, unlock the keyboard and run the matrix tester, save/load the keyboard layout. |
I am still having issues with vial recognizing my via-configured keyboard, so I haven't even been able to test beyond "software builds and runs". |
I managed to build this on a Mac but seems like it keeps opening new windows for some reason. |
I had the same problem of application endlessly spawning new instances. This seems to be fixed by adding call to multiprocessing.freeze_support() to main.py |
|
Huh, I had no idea this package used multiprocessing, but there it is:
Would you mind sending a patch for where this goes? |
|
I rebased that branch onto head, updated python to 3.12, updated Qt5 to latest, and allowed all dependencies to update accordingly. Then i removed FBS and implemented the minimum I could see that was needed to run (on windows).
This involved adding a couple json to the Vial.spec, some code to load those files, and the minimum possible amount of refactoring. There's more code that could be simplified with FBS gone, but I didn't want to go too far before getting some input and maybe getting someone to test on linux. I haven't kept a full vm handy for a couple years now...