[QPROF] Updating session params #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oualib
added
the
Performance
session_params_current allows to get the current params.
mail4umar
approved these changes
Sep 25, 2024
| @@ -239,6 +241,9 @@ class QueryProfiler: | |||
| tables_dtypes: list | |||
| Datatypes of all the loaded | |||
| performance tables. | |||
| session_params: list | |||
There was a problem hiding this comment.
Suggested change
| session_params: list | |
| session_params_non_default: list |
There was a problem hiding this comment.
You will need to change the name everywhere if you decide to accept this.
| @@ -225,6 +225,8 @@ class QueryProfiler: | |||
| Current Transaction ID. | |||
| statement_id: int | |||
| Current Statement ID. | |||
| session_params_current: dict | |||
| Current Session Parameters. | |||
There was a problem hiding this comment.
Suggested change
| Current Session Parameters. | |
| Non Default Session Parameters used | |
| to run the current/active query. |
| @@ -225,6 +225,8 @@ class QueryProfiler: | |||
| Current Transaction ID. | |||
| statement_id: int | |||
| Current Statement ID. | |||
| session_params_current: dict | |||
There was a problem hiding this comment.
Suggested change
| session_params_current: dict | |
| session_params_non_default_current: dict |
| @@ -239,6 +241,9 @@ class QueryProfiler: | |||
| tables_dtypes: list | |||
| Datatypes of all the loaded | |||
| performance tables. | |||
| session_params: list | |||
| Non Default Session Parameters used | |||
There was a problem hiding this comment.
Suggested change
| Non Default Session Parameters used | |
| List of Non Default Session Parameters used |
| @@ -239,6 +241,9 @@ class QueryProfiler: | |||
| tables_dtypes: list | |||
| Datatypes of all the loaded | |||
| performance tables. | |||
| session_params: list | |||
| Non Default Session Parameters used | |||
| to run the transactions. | |||
There was a problem hiding this comment.
Suggested change
| to run the transactions. | |
| to run all the queries that are profiled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close: