Add Client.initialize to Client OM #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| module VCloudSdk | ||
|
|
||
| class Client | ||
| attr_reader :ovdc | ||
|
|
||
| def initialize(url, username, password, entities, control, |
There was a problem hiding this comment.
Just move the methods into the private block for now.
|
Address CR comments |
|
Hi, can you see this comment? Sent from Samsung Mobile -------- Original message -------- Address CR comments — |
Qwertyn
pushed a commit
to Qwertyn/ruby_vcloud_sdk
that referenced
this pull request
Apr 27, 2015
Add classes for different network types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for creating code base for gerrit. More work/test needs to be done that. After we are on gerrit, the code review will be much clearer and easier.