This repository has been archived by the owner on May 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
fea(xo-web-6) Specification #1
Open
GHEMID-Mohamed
wants to merge
4
commits into
master
Choose a base branch
from
specification-tree-view
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,68 +1,74 @@ | ||
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
|
||
## Available Scripts | ||
|
||
In the project directory, you can run: | ||
|
||
### `npm start` | ||
|
||
Runs the app in the development mode.<br> | ||
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. | ||
|
||
The page will reload if you make edits.<br> | ||
You will also see any lint errors in the console. | ||
|
||
### `npm test` | ||
|
||
Launches the test runner in the interactive watch mode.<br> | ||
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. | ||
|
||
### `npm run build` | ||
|
||
Builds the app for production to the `build` folder.<br> | ||
It correctly bundles React in production mode and optimizes the build for the best performance. | ||
|
||
The build is minified and the filenames include the hashes.<br> | ||
Your app is ready to be deployed! | ||
|
||
See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. | ||
|
||
### `npm run eject` | ||
|
||
**Note: this is a one-way operation. Once you `eject`, you can’t go back!** | ||
|
||
If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | ||
|
||
Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own. | ||
|
||
You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it. | ||
|
||
## Learn More | ||
|
||
You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started). | ||
|
||
To learn React, check out the [React documentation](https://reactjs.org/). | ||
|
||
### Code Splitting | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting | ||
|
||
### Analyzing the Bundle Size | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size | ||
|
||
### Making a Progressive Web App | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app | ||
|
||
### Advanced Configuration | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration | ||
|
||
### Deployment | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/deployment | ||
|
||
### `npm run build` fails to minify | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify | ||
## Specification | ||
|
||
### Views | ||
|
||
In Xen Orchestra 6 release, a tree view will be added in order to display objects heicically. | ||
In order to achieve this, a default map tree view should be set. | ||
|
||
#### Basic tree | ||
```bash | ||
pool | ||
│ | ||
├── VM | ||
│ ├── VBD | ||
│ └── VIF | ||
├── VM_template | ||
├── VM_snapshot | ||
├── VM_controller | ||
├── host | ||
│ ├── FGPU | ||
│ ├── PBD | ||
│ ├── PCI | ||
│ └── PIF | ||
├── SR | ||
│ ├── VDI | ||
│ ├── VDI_snapshot | ||
│ └── VDI_unmanaged | ||
└── network | ||
``` | ||
|
||
#### Infinite tree | ||
|
||
```bash | ||
pool | ||
│ | ||
├── VM | ||
│ ├── VBD | ||
│ ├── VIF | ||
│ │ └── network | ||
│ │ └── VIF | ||
│ │ └── network | ||
│ │ └── VIF | ||
│ │ └── ∞ | ||
│ └── VM_snapshot | ||
├── VM_template | ||
│ ├── VBD | ||
│ └── VM_snapshot | ||
├── VM_controller | ||
│ ├── VBD | ||
│ └── VM_snapshot | ||
├── host | ||
│ ├── FGPU | ||
│ ├── PBD | ||
│ └── PCI | ||
├── SR | ||
│ ├── VDI | ||
│ ├── VDI_snapshot | ||
│ └── VDI_unmanaged | ||
└── Network | ||
├── VIF | ||
└── PIF | ||
``` | ||
|
||
- Make Resizable panes when the tree view exceeds the default width | ||
|
||
### Filtering | ||
|
||
#### View (saved, uncollapsable) | ||
- name | ||
- filter: only on top-level objects | ||
- group by: type, tag, folder, ... | ||
|
||
#### Manual search | ||
- Filter all XO objects | ||
- For each object, go up the infra until you find a top-level node to determine path |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I delete it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, but as we said tomorrow in the meeting, it's not at the correct position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a
VM_controller
object. As I see, it's linked to apool
and aVBD
.Where do you think it's the right position ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also linked to the host (
$container
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that a
$container
is a$host
.. So I should move all VM types underneath host, what do you think ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
$container
is not always a host, it can be a pool if the VM is not on a specific host (not running and disks on shared SR).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so putting it under a
host
is a bad idea, I think that we should keep it underneath apool
,