Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application.js if missing #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlugner
Copy link

@jlugner jlugner commented Oct 20, 2022

As mentioned in #252 rails 6+ doesn't generate the required javascript entry point for godmins install_generator. Below approach is likely an overly naive solution but should do the trick for projects running rails 6+. I've done some basic testing for both the Engine installation and standalone installations for latest versions of rails 6 and 7, and it seems to work.

@jlugner
Copy link
Author

jlugner commented Oct 20, 2022

Failing build seems to be Capybara not playing well with the recent release of Puma 6.0. Fixed on Capybara#master, so probably overkill to lock the version here. New version should be out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant