Fix the randomness while in benchmarking mode #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberosa
reviewed
Jul 16, 2024
| @@ -137,12 +137,14 @@ def update_weighted_accuracy(self) -> None: | |||
| for tool, acc_info in self.accuracy_store.items() | |||
| } | |||
|
|
|||
| def select_tool(self, randomness: RandomnessType) -> Optional[str]: | |||
| def select_tool(self, randomness: RandomnessType = None) -> Optional[str]: | |||
There was a problem hiding this comment.
you do not need to change the calls to this function so that only once the seed is past as a parameter?
cyberosa
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The randomness should only be set once when benchmarking.