Implement a multiplexer for the tx settlement skill #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overcomes a framework’s limitation, which is: chaining a skill more than once. The limitation appears because we need to perform a refactor for sending a safe tx for performing a request to the mech instead of using the mech client, because the latter requires the ethereum private key's path. Therefore, will need to send a safe tx both for a) performing a request to the mech and b) placing a bet.
Adamantios
commented
Jul 17, 2023
| service_id: market_manager_estimation | ||
| service_id: market_manager |
There was a problem hiding this comment.
Unrelated change.
Adamantios
commented
Jul 17, 2023
| service_id: market_manager_estimation | ||
| service_id: trader |
There was a problem hiding this comment.
Unrelated change.
```
Error: Event reference check failed with
- PostTxSettlementRound: transition function events {'BET_PLACEMENT_DONE', 'UNRECOGNIZED', 'DECISION_MAKING_DONE'} do not match referenced events {'UNRECOGNIZED'}.
```
https://github.com/valory-xyz/trader/actions/runs/5575978370/jobs/10186608899?pr=16#step:10:71
0xArdi
approved these changes
Jul 17, 2023
dvilelaf
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a multiplexer for the tx settlement skill to overcome a framework's limitation.
The limitation arises from the necessity to refactor the process of making a request to the mech. This refactoring will bypass the need for the Ethereum private key's path by replacing the mech client. Consequently, to accommodate this change, we will employ a safe transaction via the tx settlement skill.
As a result, we will utilize the tx settlement to perform a safe transaction for two purposes: a) making requests to the mech, and b) placing bets.