Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/optimize report #9

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Chore/optimize report #9

merged 7 commits into from
Sep 16, 2024

Conversation

gauravlochab
Copy link
Collaborator

Refactored the wallet_info, staking_report, and report scripts to improve code modularity by extracting common functions into a shared utils module.
Key changes include:

  • Modularized shared functions such as balance handling, color coding, and status printing.
  • Implemented consistent error handling and logging across all scripts.
  • Enhanced threshold checks and warnings for Safe and Agent balances.

@0xArdi
Copy link
Collaborator

0xArdi commented Sep 16, 2024 •
edited
Loading

Do you mind re-basing to my branch? fix/fund-ops

@0xArdi 0xArdi changed the base branch from main to fix/fund-ops September 16, 2024 12:35
@gauravlochab
Copy link
Collaborator Author

Do you mind re-basing to my branch? fix/fund-ops

sure let me do that

@gauravlochab
Copy link
Collaborator Author

Do you mind re-basing to my branch? fix/fund-ops

sure let me do that

done, no conflicts!

@gauravlochab gauravlochab merged commit 4e44940 into fix/fund-ops Sep 16, 2024
1 of 3 checks passed
@gauravlochab gauravlochab deleted the chore/optimize-report branch September 24, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xArdi 0xArdi Awaiting requested review from 0xArdi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gauravlochab @0xArdi