fix: common checks #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravlochab
requested review from
0xArdi and
dagacha
and removed request for
dagacha
Adamantios
reviewed
Sep 23, 2024
operate/cli.py
Outdated
|
|
||
| # type: ignore |
Adamantios
reviewed
Sep 23, 2024
operate/services/service.py
Outdated
| chain_id: str = "100", | ||
| chain_id: str = "100", # pylint: disable=unused-argument |
There was a problem hiding this comment.
Why disable and not remove instead?
There was a problem hiding this comment.
removed in next push
There was a problem hiding this comment.
Hmm I still cannot see where the _chain_id is used in the method.
Adamantios
reviewed
Sep 23, 2024
operate/services/service.py
Outdated
|
|
||
| # type: ignore |
There was a problem hiding this comment.
Why ignore the whole file?
Adamantios
reviewed
Sep 23, 2024
operate/services/protocol.py
Outdated
Comment on lines
20
to
21
| # type: ignore | ||
| """This module implements the onchain manager.""" |
There was a problem hiding this comment.
Why ignore the whole file?
Adamantios
reviewed
Sep 23, 2024
| @@ -650,7 +656,7 @@ async def _deploy_service_onchain(request: Request) -> JSONResponse: | |||
| operate.service_manager().deploy_service_onchain( | |||
| hash=request.path_params["service"] | |||
| ) | |||
| operate.service_manager().stake_service_on_chain( | |||
| operate.service_manager().stake_service_on_chain( # pylint: disable=no-value-for-parameter | |||
There was a problem hiding this comment.
The definition seems to require more args:
optimus-quickstart/operate/services/manage.py
Line 888 in bec0de5
There was a problem hiding this comment.
the endpoint not used yet and the function in not implemented
Adamantios
reviewed
Sep 23, 2024
| @@ -17,6 +17,7 @@ | |||
| # limitations under the License. | |||
| # | |||
| # ------------------------------------------------------------------------------ | |||
| # type: ignore | |||
Adamantios
approved these changes
Sep 23, 2024
dagacha
approved these changes
Sep 23, 2024
gauravlochab
requested review from
Adamantios and
xvalex15
and removed request for
0xArdi and
Adamantios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has code cleanup and changes for common checks