-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (deploy): Port localhost deployment code #2258
base: main
Are you sure you want to change the base?
Conversation
9604d73
to
9854546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super excited for this one
@@ -154,7 +154,7 @@ def __init__(self, logger: logging.Logger, dump_dir: Optional[Path] = None) -> N | |||
|
|||
self.resets = 0 | |||
self.logger = logger | |||
self.dump_dir = dump_dir or Path("/tm_state") | |||
self.dump_dir = dump_dir or Path(os.environ["TMSTATE"] or "/tm_state") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to the docs somewhere btw?
Also would be nice to able to set an alias for the agent.
It's in aea fetch AGENT --alias
command group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! do you know any good place to add the docs? I'm guessing the docstring of def create_server()
?
Signed-off-by: OjusWiZard <[email protected]>
9854546
to
8e9a19b
Compare
Signed-off-by: OjusWiZard <[email protected]>
Signed-off-by: OjusWiZard <[email protected]>
cb27189
to
3c1f5aa
Compare
WIP (deploy): Integrate non-docker logic with CLI
3c1f5aa
to
2d752cf
Compare
Proposed changes
Porting the code from Pearl to here that runs an agent on local host system without docker.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.Further comments