Implement a custom filtering method #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a custom filtering method to handle potential RPC timeouts or hanging.
Adamantios
force-pushed
the
feat/handle-rpc-timeouts
branch
from
95db6f9
to
55bbd35
Compare
Comment on lines
+374
to
+394
| def rpc_call_with_timeout(func: Callable, timeout: int) -> Any: | ||
| """Execute an RPC call with a timeout.""" | ||
|
|
||
| with concurrent.futures.ThreadPoolExecutor(RPC_CALL_MAX_WORKERS) as executor: | ||
| # submit the function with the RPC call to the executor | ||
| future = executor.submit(func) | ||
|
|
||
| try: | ||
| # wait for the result with a timeout | ||
| data = future.result(timeout=timeout) | ||
| except TimeoutError: | ||
| # handle the case where the execution times out | ||
| err = f"The RPC didn't respond within {timeout} seconds." | ||
| return None, err | ||
|
|
||
| # check if an error occurred | ||
| if isinstance(data, str): | ||
| # handle the case where the execution fails | ||
| return None, data | ||
|
|
||
| return data, None |
There was a problem hiding this comment.
I don't understand the purpose of this method, you're creating a thread pool executor and you're only submitting one function at a time which means you're basically executing one function at a time instead of executing multiple function calls parallely
There was a problem hiding this comment.
It's basically for the timeout to avoid hanging:
| filtering_operation = self.batch_filter_wrapper( | ||
| event, match_single, match_any, to_block_adj, from_block | ||
| ) | ||
| batch_result, err = rpc_call_with_timeout(filtering_operation, timeout) |
angrybayblade
approved these changes
Apr 22, 2024
0xArdi
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement a custom filtering method to handle RPC timeouts.
Fixes
Fixes valory-xyz/open-autonomy#2121.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.Further comments
n/a