Add whitelist for component mint check #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybayblade
commented
Apr 11, 2024
Comment on lines
+1
to
+28
| agent/fetchai/error_test | ||
| agent/fetchai/gym_aea | ||
| agent/fetchai/my_first_aea | ||
| agent/open_aea/gym_aea | ||
| agent/open_aea/http_echo | ||
| agent/open_aea/my_first_aea | ||
| connection/fetchai/gym | ||
| connection/fetchai/local | ||
| connection/fetchai/stub | ||
| connection/valory/test_libp2p | ||
| contract/fetchai/erc1155 | ||
| protocol/fetchai/default | ||
| protocol/fetchai/fipa | ||
| protocol/fetchai/gym | ||
| protocol/fetchai/oef_search | ||
| protocol/fetchai/state_update | ||
| protocol/fetchai/tac | ||
| skill/fetchai/echo | ||
| skill/fetchai/erc1155_client | ||
| skill/fetchai/erc1155_deploy | ||
| skill/fetchai/error | ||
| skill/fetchai/error_test_skill | ||
| skill/fetchai/fipa_dummy_buyer | ||
| skill/fetchai/generic_buyer | ||
| skill/fetchai/generic_seller | ||
| skill/fetchai/gym | ||
| skill/fetchai/http_echo | ||
| skill/fetchai/task_test_skill |
Comment on lines
+29
to
+36
| connection/valory/http_client | ||
| connection/valory/http_server | ||
| connection/valory/ledger | ||
| connection/valory/p2p_libp2p_client | ||
| protocol/valory/acn | ||
| protocol/valory/contract_api | ||
| protocol/valory/http | ||
| protocol/valory/ledger_api |
There was a problem hiding this comment.
Already minted on other repos
There was a problem hiding this comment.
Can we add inline comments for posterity?
DavidMinarsch
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.