Fix IPFS node address parsing on Git console #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybayblade
commented
Mar 12, 2024
Comment on lines
+141
to
+147
| def test_node_addr_cleanup() -> None: | ||
| """Test node address clean up method.""" | ||
|
|
||
| original_addr = "/dns/to/some/node" | ||
| consoled_parsed_addr = f"C:/Git/bin/{original_addr}" | ||
| with patch("platform.system", return_value="Windows"): | ||
| assert _clean_ipfs_node_url(ipfs_node=consoled_parsed_addr) == original_addr |
There was a problem hiding this comment.
@jmoreira-valory this will take care of the corrupted node strings
Comment on lines
+146
to
+149
| if platform.system() != "Windows": | ||
| return ipfs_node | ||
| if not ipfs_node.startswith("C:/"): | ||
| return ipfs_node |
There was a problem hiding this comment.
Can you just remove this piece of code? seems the lines below would sanitize it always, even in more general cases, no?
Suggested change
| if platform.system() != "Windows": | |
| return ipfs_node | |
| if not ipfs_node.startswith("C:/"): | |
| return ipfs_node |
There was a problem hiding this comment.
Problem is, this issue is git console and windows specific only. If we don't have this check and sanitise always, we might end up overlooking some other issue. So for now let's keep this specific to one issue.
jmoreira-valory
approved these changes
Mar 12, 2024
0xArdi
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.