Include ledger specifier when writing keys in a JSON file #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybayblade
commented
Jan 23, 2024
Comment on lines
+169
to
+171
| key_pairs.append( | ||
| {ADDRESS: crypto.address, PRIVATE_KEY: priv_key, LEDGER: type_} | ||
| ) |
There was a problem hiding this comment.
This ledger specifier will be used by the deployment builder to write keys for the agents. The solana deployments failed because the deployment builder was writing solana keys as ethereum keys since there was no specifier in the keys.json file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 90.25% 90.26% +0.01%
==========================================
Files 371 371
Lines 29816 29817 +1
==========================================
+ Hits 26910 26914 +4
+ Misses 2906 2903 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dvilelaf
previously approved these changes
Jan 23, 2024
Adamantios
previously approved these changes
Jan 23, 2024
Release `v1.46.0`
angrybayblade
dismissed stale reviews from Adamantios and dvilelaf
via
620f71e
dvilelaf
approved these changes
Jan 23, 2024
Adamantios
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.