Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forked dependencies #665

Merged
merged 35 commits into from
Sep 26, 2023
Merged

Conversation

angrybayblade
Copy link

@angrybayblade angrybayblade commented Sep 18, 2023

Proposed changes

This PR

  • Removes the web3py fork as a dependency
  • Bumps the protobuf
  • Updates protocol buffers compiler to compatible version
  • Updates the protocol generator

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

setup.py Outdated Show resolved Hide resolved
@angrybayblade angrybayblade changed the title [WIP] Remove forked dependencies Remove forked dependencies Sep 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (391552e) 92.31% compared to head (e5fc97e) 91.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   92.31%   91.99%   -0.33%     
==========================================
  Files         371      371              
  Lines       29647    29539     -108     
==========================================
- Hits        27370    27175     -195     
- Misses       2277     2364      +87     
Flag Coverage Δ
unittests 91.99% <38.82%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aea/__init__.py 100.00% <100.00%> (ø)
aea/cli/__init__.py 100.00% <ø> (ø)
aea/cli/generate_all_protocols.py 97.20% <100.00%> (ø)
aea/configurations/constants.py 100.00% <ø> (ø)
aea/helpers/ipfs/__init__.py 100.00% <100.00%> (ø)
aea/helpers/ipfs/base.py 100.00% <100.00%> (ø)
aea/helpers/ipfs/pb/merkledag_pb2.py 100.00% <100.00%> (ø)
aea/helpers/ipfs/pb/unixfs_pb2.py 100.00% <100.00%> (ø)
aea/helpers/multiaddr/base.py 100.00% <100.00%> (ø)
aea/mail/base.py 100.00% <100.00%> (ø)
... and 40 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@solarw solarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angrybayblade angrybayblade merged commit c4be6cd into main Sep 26, 2023
35 of 36 checks passed
@DavidMinarsch DavidMinarsch deleted the fix/remove-forked-dependencies branch October 12, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants