Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide the user with the time information regarding when the current epoch ends and how long until an eviction expires. #380

Merged
merged 9 commits into from
Oct 4, 2024
Merged

feat: Provide the user with the time information regarding when the current epoch ends and how long until an eviction expires. #380

merged 9 commits into from
Oct 4, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Oct 1, 2024 •
edited
Loading

Proposed changes

  • Eviction expiration date (the date shown in the screenshot is just for testing)
Screensho2
  • Show approximate epoch end time
Screensho1

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 added the enhancement New feature or request label Oct 1, 2024
@mohandast52 mohandast52 self-assigned this Oct 1, 2024
@mohandast52 mohandast52 changed the base branch from main to staging October 1, 2024 12:03
@mohandast52 mohandast52 marked this pull request as ready for review October 2, 2024 14:14
@mohandast52 mohandast52 merged commit aca3ee9 into staging Oct 4, 2024
4 checks passed
@mohandast52 mohandast52 deleted the mohan/epoch-ends-and-eviction-expires branch October 4, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

@truemiller truemiller truemiller approved these changes

@iasonrovis iasonrovis Awaiting requested review from iasonrovis

Assignees

@mohandast52 mohandast52

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohandast52 @Tanya-atatakai @truemiller