Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featuring SQ mech tool #240

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Featuring SQ mech tool #240

wants to merge 10 commits into from

Conversation

bgodlin
Copy link

@bgodlin bgodlin commented Jun 11, 2024

Proposed changes

Introducing a new mech tool

Fixes

N/A

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

N/A

Copy link
Collaborator

@0xArdi 0xArdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bgodlin . Can you please add at least 1 test?
Example here: https://github.com/valory-xyz/mech/blob/main/tests/test_tools.py#L106

@dvilelaf
Copy link
Collaborator

@bgodlin will you be able to address the comment from Ardian?

@bgodlin bgodlin marked this pull request as draft July 2, 2024 13:35
@0xArdi 0xArdi marked this pull request as ready for review July 2, 2024 13:46
@0xArdi
Copy link
Collaborator

0xArdi commented Jul 2, 2024

@bgodlin can you address merge conflicts?

@bgodlin
Copy link
Author

bgodlin commented Jul 23, 2024

@0xArdi Minor adjustments have been made to the project. Rather than merely accepting the query and explaining the output from the indexer that receives it, the tool now assists in constructing a query from natural language.

However, there is still room for improvement in terms of quality:

  1. Due to certain specific keyword arguments, the test does not inherit from BaseToolTest.
  2. So far, the tool has only been tested with OpenAI.
  3. The current naming convention may be misleading; chain_data_interpreter might be a more appropriate choice.

Furthermore, as indicated by the failing CI, the unit tests are not passing. This issue is specifically related to the TestPredictionOnline and TestOmenTransactionBuilder tests.

@@ -0,0 +1,53 @@
query_examples = """
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright header is missing here, which the CI complains about

Comment on lines 11 to 14
openai:
version: ==1.11.0
tiktoken:
version: ==0.5.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openai:
version: ==1.11.0
tiktoken:
version: ==0.5.1
openai:
version: ==1.11.0
tiktoken:
version: ==0.5.1
requests: {}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI complains about this

Copy link
Collaborator

@0xArdi 0xArdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of required changes to address CI failures

@@ -0,0 +1,15 @@
name: graphql_response_analyser
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some missing required fields here:

aea.exceptions.AEAValidationError: The following errors occurred during validation:
 - : 'fingerprint' is a required property
 - : 'fingerprint_ignore_patterns' is a required property

Copy link
Collaborator

@0xArdi 0xArdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more check failures, i left a comment what needs to be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants