Feat/keychain #229
Merged
Feat/keychain #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/packages.json # packages/valory/agents/mech/aea-config.yaml # packages/valory/customs/prediction_request/component.yaml # packages/valory/services/mech/service.yaml # packages/valory/skills/task_execution/skill.yaml
dvilelaf
approved these changes
May 23, 2024
Comment on lines
+59
to
+65
| def __getitem__(self, service_name: str) -> str: | ||
| """Get the current API key for a given service.""" | ||
| if service_name not in self.services: | ||
| raise KeyError(f"Service '{service_name!r}' not found in KeyChain.") | ||
|
|
||
| index = self.current_index[service_name] | ||
| return self.services[service_name][index] |
There was a problem hiding this comment.
Why not simply rotate the key here ?
There was a problem hiding this comment.
We only want to rotate in case it has been exhausted.
# Conflicts: # packages/packages.json # poetry.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds support for key rotation by introducing a new
KeyChainobject that serves as a key manager.Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...