chore(ci): check e2e main commits against Android API level 24
#6031
+16
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6031 +/- ##
========================================
Coverage 88.76% 88.76%
========================================
Files 728 728
Lines 30835 30835
Branches 5334 5640 +306
========================================
Hits 27372 27372
Misses 3421 3421
Partials 42 42 Continue to review full report in Codecov by Sentry.
|
#6124) replace "stablecoin references with "crypto" or "crypto assets" --------- Co-authored-by: Kathy Luo <[email protected]>
) ### Description Also fix TVL, now assume that TVL is always in USD (will add note in hooks). ### Test plan Manual test: <img src="https://github.com/user-attachments/assets/3fe943f0-ffe9-446a-afd1-dc47d7ea9ed1" width="250" /> <img src="https://github.com/user-attachments/assets/6661ba15-e8ce-40e2-ac74-e693061e3ca6" width="250" /> ### Related issues - Fixes ACT-1397 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
### Description Allow for showing provider docs and valora T&Cs if provider T&Cs don't exist ### Test plan <img src="https://github.com/user-attachments/assets/78e09a87-1153-4287-bfc5-8471f64a3da0" width="250" /> https://github.com/user-attachments/assets/a3ea05b2-a4f7-49c7-b753-745f62290c27 ### Related issues - Fixes ACT-1399 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Co-authored-by: Valora Bot <[email protected]>
(#6129) Co-authored-by: Anka <[email protected]>
…6130) ### Description withdrawToken is not 1:1 with depositToken, need to convert withdrawToken balance to depositToken using pricePerShare ### Test plan Without change (mismatch): https://github.com/user-attachments/assets/160417bf-9047-4a63-ae16-5568c08a6861 With change (no mismatch): https://github.com/user-attachments/assets/f4e01cd0-9005-4c99-a9b8-2a4d7e013fad ### Related issues - Fixes N/A ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Co-authored-by: Valora Bot <[email protected]>
### Description Remove all references of SHOW_MULTIPLE_EARN_POOLS and SHOW_STABLECOIN_EARN. Remove pool card from the Aave pool token details screen. Follow up to remove Aave pool token from token details list: https://linear.app/valora/issue/ACT-1404/dont-show-aave-pool-token-on-token-list-version-=195 ### Test plan Unit tests updated, CI and knip. Ran wallet locally and went through multi-pool earn screens, nothing broken, no warnings or errors. ### Related issues - Fixes ACT-1365 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [i18next](https://www.i18next.com) ([source](https://redirect.github.com/i18next/i18next)) | [`^23.15.1` -> `^23.15.2`](https://renovatebot.com/diffs/npm/i18next/23.15.1/23.15.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>i18next/i18next (i18next)</summary> ### [`v23.15.2`](https://redirect.github.com/i18next/i18next/blob/HEAD/CHANGELOG.md#23152) [Compare Source](https://redirect.github.com/i18next/i18next/compare/v23.15.1...v23.15.2) - fix(types): make context related keys detection stricter [2243](https://redirect.github.com/i18next/i18next/pull/2243) fixes [2242](https://redirect.github.com/i18next/i18next/issues/2242) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
### Description If the positions corresponds to a pool, navigate to the pool info page, otherwise open an internal browser with `manageUrl`. ### Test plan **Manual:** EarnPosition: https://github.com/user-attachments/assets/43e67b34-5b06-4cec-b34e-36adcb2e4f84 Position: https://github.com/user-attachments/assets/be13ed9c-81bf-4cbe-bd17-c310076a1a3e ### Related issues - Fixes ACT-1383 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
#6139) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fiatconnect/fiatconnect-sdk](https://redirect.github.com/fiatconnect/fiatconnect-sdk) | [`^0.5.58` -> `^0.5.59`](https://renovatebot.com/diffs/npm/@fiatconnect%2ffiatconnect-sdk/0.5.58/0.5.59) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fiatconnect/fiatconnect-sdk (@​fiatconnect/fiatconnect-sdk)</summary> ### [`v0.5.59`](https://redirect.github.com/fiatconnect/fiatconnect-sdk/releases/tag/v0.5.59) [Compare Source](https://redirect.github.com/fiatconnect/fiatconnect-sdk/compare/v0.5.58...v0.5.59) ##### Bug Fixes - **deps:** update dependency ethers to ^6.13.3 ([#​308](https://redirect.github.com/fiatconnect/fiatconnect-sdk/issues/308)) ([1ef7f10](https://redirect.github.com/fiatconnect/fiatconnect-sdk/commit/1ef7f1069bc3d169781b3399f7522e854a686e3e)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTQuMCIsInVwZGF0ZWRJblZlciI6IjM4LjExNC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
### Description https://linear.app/valora/issue/ACT-1407/earn-pool-info-screen-ui-improvement https://github.com/user-attachments/assets/2dd38a0d-a9b9-4f10-beb0-6d10cc310b0f | Before |After | | --- | --- | | <img src="https://github.com/user-attachments/assets/1084f9f7-83d3-4fff-82cc-5df345e8f19b" width="250px"> | <img src="https://github.com/user-attachments/assets/2dd38a0d-a9b9-4f10-beb0-6d10cc310b0f" width="250px"> | ### Test plan tested manually
### Description 1st PR for RET-1207. It adds RTK-Query and api slice for the new Transaction Feed V2. All the reducers up to this point were always manually maintained/changed by us. For this purpose, we have Redux migrations which are covered with tests to ensure compatibility between different versions of Redux state. With introduction of RTK-Query we introduce library-managed api reducers, which _**must not**_ be manually tweaked as library can change how it stores its structure (api reducer is a **cache** for API endpoint). For this purpose, it is mandatory to omit api reducers completely from the flow of `typescript-json-schema` generation. This implemenation moves existing reducers to a separate file as generating schema with api reducers throws an error of unsupported type from `@reduxjs/tookit/query/react`. This new Transaction Feed V2 (that is gonna be implemented over a few PRs) is intended to completely replace existing [TransactionFeed](https://github.com/valora-inc/wallet/blob/main/src/transactions/feed/TransactionFeed.tsx), [queryHelper](https://github.com/valora-inc/wallet/blob/main/src/transactions/feed/queryHelper.ts) and corresponding test files. It will be closed behind the feature gate from Statsig for the initial release. ### Test plan With this implementation, all the existing tests are working and there is no issues with persistence as the api reducers are completely omitted from the persistence flow. Transactions persistence for Transaction Feed V2 will be implemented in the follow-up PRs. ### Related issues - Relates to RET-1207 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Co-authored-by: Valora Bot <[email protected]>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@reduxjs/toolkit](https://redux-toolkit.js.org) ([source](https://redirect.github.com/reduxjs/redux-toolkit)) | [`^2.2.7` -> `^2.2.8`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/2.2.7/2.2.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/redux-toolkit (@​reduxjs/toolkit)</summary> ### [`v2.2.8`](https://redirect.github.com/reduxjs/redux-toolkit/releases/tag/v2.2.8) [Compare Source](https://redirect.github.com/reduxjs/redux-toolkit/compare/v2.2.7...v2.2.8) This **bugfix** release fixes a long-standing issue with RTK Query lazy query triggers returning stale data in some cases, fixes an error handling issue in RTK Query, and exports additional TS types. #### Changelog ##### Lazy Query Trigger Handling We'd had a couple long-standing issues reporting that `const result = await someLazyQueryTrigger()` sometimes returned stale data, especially if a mutation had just invalidated that query's tag. We finally got a good repro of this issue and identified it as a mis-written call inside of the middleware that skipped past the necessary handling to activate the correct query status tracking in that scenario. This should now be fixed. ##### Other Changes Timeout handling in RTKQ endpoints should now correctly throw a timeout-related error instead of an `AbortError`. Base queries now have access to the current `queryCacheKey` value so it can be used in deciding query logic. We've exported several more TS types related to query options, as some users have been depending on those even though they previously weren't part of the public API. #### What's Changed - Export `QueryExtraOptions` and `MutationExtraOptions` by [@​aryaemami59](https://redirect.github.com/aryaemami59) in [https://github.com/reduxjs/redux-toolkit/pull/4556](https://redirect.github.com/reduxjs/redux-toolkit/pull/4556) - Fix `mangleErrors` not preserving different error types by [@​aryaemami59](https://redirect.github.com/aryaemami59) in [https://github.com/reduxjs/redux-toolkit/pull/4586](https://redirect.github.com/reduxjs/redux-toolkit/pull/4586) - Add the `TypedUseQueryStateOptions` helper type by [@​aryaemami59](https://redirect.github.com/aryaemami59) in [https://github.com/reduxjs/redux-toolkit/pull/4604](https://redirect.github.com/reduxjs/redux-toolkit/pull/4604) - feat(baseQuery): expose queryCacheKey in baseQuery by [@​HaakonSvane](https://redirect.github.com/HaakonSvane) in [https://github.com/reduxjs/redux-toolkit/pull/4636](https://redirect.github.com/reduxjs/redux-toolkit/pull/4636) - Fix `AbortError` being triggered incorrectly on `createApi` endpoint timeout by [@​andrejpavlovic](https://redirect.github.com/andrejpavlovic) in [https://github.com/reduxjs/redux-toolkit/pull/4628](https://redirect.github.com/reduxjs/redux-toolkit/pull/4628) - type: export QueryReturnValue by [@​hornta](https://redirect.github.com/hornta) in [https://github.com/reduxjs/redux-toolkit/pull/4640](https://redirect.github.com/reduxjs/redux-toolkit/pull/4640) - call `initiate` to refetch queries from middleware by [@​phryneas](https://redirect.github.com/phryneas) in [https://github.com/reduxjs/redux-toolkit/pull/4651](https://redirect.github.com/reduxjs/redux-toolkit/pull/4651) **Full Changelog**: reduxjs/redux-toolkit@v2.2.7...v2.2.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTUuMSIsInVwZGF0ZWRJblZlciI6IjM4LjExNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@sentry/react-native](https://redirect.github.com/getsentry/sentry-react-native) | [`^5.33.1` -> `^5.33.2`](https://renovatebot.com/diffs/npm/@sentry%2freact-native/5.33.1/5.33.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>getsentry/sentry-react-native (@​sentry/react-native)</summary> ### [`v5.33.2`](https://redirect.github.com/getsentry/sentry-react-native/blob/HEAD/CHANGELOG.md#5332) [Compare Source](https://redirect.github.com/getsentry/sentry-react-native/compare/5.33.1...5.33.2) ##### Fixes - Emits Bridge log only in debug mode ([#​4145](https://redirect.github.com/getsentry/sentry-react-native/pull/4145)) - Remove unused `spanName` from `TimeToDisplayProps` ([#​4150](https://redirect.github.com/getsentry/sentry-react-native/pull/4150)) ##### Dependencies - Bump JavaScript SDK from v7.119.0 to v7.119.1 ([#​4149](https://redirect.github.com/getsentry/sentry-react-native/pull/4149)) - [changelog](https://redirect.github.com/getsentry/sentry-javascript/blob/v7/CHANGELOG.md#71191) - [diff](https://redirect.github.com/getsentry/sentry-javascript/compare/7.119.0...7.119.1) - Bump CLI from v2.36.1 to v2.36.6 ([#​4116](https://redirect.github.com/getsentry/sentry-react-native/pull/4116), [#​4131](https://redirect.github.com/getsentry/sentry-react-native/pull/4131), [#​4137](https://redirect.github.com/getsentry/sentry-react-native/pull/4137), [#​4144](https://redirect.github.com/getsentry/sentry-react-native/pull/4144)) - [changelog](https://redirect.github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#2366) - [diff](https://redirect.github.com/getsentry/sentry-cli/compare/2.36.1...2.36.6) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTUuMSIsInVwZGF0ZWRJblZlciI6IjM4LjExNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <[email protected]>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-video](https://thewidlarzgroup.github.io/react-native-video/) ([source](https://redirect.github.com/TheWidlarzGroup/react-native-video)) | [`^6.6.2` -> `^6.6.4`](https://renovatebot.com/diffs/npm/react-native-video/6.6.2/6.6.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TheWidlarzGroup/react-native-video (react-native-video)</summary> ### [`v6.6.4`](https://redirect.github.com/TheWidlarzGroup/react-native-video/blob/HEAD/CHANGELOG.md#664-2024-10-03) [Compare Source](https://redirect.github.com/TheWidlarzGroup/react-native-video/compare/v6.6.3...v6.6.4) ##### Features - **android:** add live video label configuration ([#​4190](https://redirect.github.com/TheWidlarzGroup/react-native-video/issues/4190)) ([149924f](https://redirect.github.com/TheWidlarzGroup/react-native-video/commit/149924ffcb0cbdeaa8c671ebb4b3b6115920131a)) ### [`v6.6.3`](https://redirect.github.com/TheWidlarzGroup/react-native-video/blob/HEAD/CHANGELOG.md#663-2024-09-29) [Compare Source](https://redirect.github.com/TheWidlarzGroup/react-native-video/compare/v6.6.2...v6.6.3) ##### Bug Fixes - **android:** bad rotation handling ([#​4205](https://redirect.github.com/TheWidlarzGroup/react-native-video/issues/4205)) ([3ecf324](https://redirect.github.com/TheWidlarzGroup/react-native-video/commit/3ecf324bb30208ab8efbf00958ebd4590ddf8d39)) - **docs:** invalid URLs in updating section ([#​4201](https://redirect.github.com/TheWidlarzGroup/react-native-video/issues/4201)) ([c81eea5](https://redirect.github.com/TheWidlarzGroup/react-native-video/commit/c81eea54d8291c5131fd59a93f198e0fd5f3673c)) - **ios:** Add safety checks and remove some of the ! in types declaration ([#​4182](https://redirect.github.com/TheWidlarzGroup/react-native-video/issues/4182)) ([ae82c83](https://redirect.github.com/TheWidlarzGroup/react-native-video/commit/ae82c83eef2fc7c383fd844c7471613e4ac1c7ee)) - **tvos:** typo ([#​4204](https://redirect.github.com/TheWidlarzGroup/react-native-video/issues/4204)) ([b11f05f](https://redirect.github.com/TheWidlarzGroup/react-native-video/commit/b11f05f1753a4cb963b94d1e1d8d1f6c37af2a9d)) ##### Features - **android:** allow to hide specific controls ([#​4183](https://redirect.github.com/TheWidlarzGroup/react-native-video/issues/4183)) ([279cc0e](https://redirect.github.com/TheWidlarzGroup/react-native-video/commit/279cc0e5ed712488fc3c153c62b14f13048103f2)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTUuMSIsInVwZGF0ZWRJblZlciI6IjM4LjExNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <[email protected]>
Co-authored-by: Valora Bot <[email protected]>
### Description Here's an improved version of a basic script I was using locally to generate release notes. Features: - generate release notes for both "main" and "patch" releases - excludes cherry-picked commits from the previous release - detects tag prefix so it also works for Mobile Stack (i.e. no hardcoded "valora") - verbose mode by default showing what it does (see screenshot), printed to `stderr` so we can pipe `stdout` and get just the release notes Example usages: - `yarn generate-release-notes` this is the recommended usage - `yarn generate-release-notes --lastTag valora-v1.94.2` - `yarn generate-release-notes --lastTag valora-v1.94.2 --toRef someRef` In the future, the plan is to use it from our release workflow to create the GitHub Release automatically. We could also update the nightly workflow to use it. ### Test plan Successfully used it to generate the release notes for [1.95.0](https://github.com/valora-inc/wallet/releases/tag/valora-v1.95.0) <img width="679" alt="Screenshot 2024-10-04 at 16 25 16" src="https://github.com/user-attachments/assets/c55a10d8-d5b0-4f06-81d8-575ae3677e80"> Successfully used it to generate the release for 1.95.1 <img width="633" alt="Screenshot 2024-10-04 at 17 40 19" src="https://github.com/user-attachments/assets/e155460f-cb1b-4a64-8bb2-5e2f6b97e4a4"> ### Related issues - Slack [thread](https://valora-app.slack.com/archives/C025V1D6F3J/p1724326960482299) for context. ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
…n Feed V2 (#6146) ### Description 4th PR of RET-1207. This implements the cleanup of confirmed stand by transactions that are already present in the feed. Currently, we keep confirmed transactions in `standByTransactions` even if they are present in the pagination data. This is unnecessary as it takes extra space from the persisted storage. ### Test plan - changed the test that checks merging of pages with stand by transactions - added test to check if the stand by transaction was correctly removed if it appeared in the pagination data ### Related issues - Relates to RET-1207 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
…6151) ### Description 5th PR for RET-1207. Adds error handling middleware as per [the docs](https://redux-toolkit.js.org/rtk-query/usage/error-handling) and also copies the same logic of error handling from [queryHelper](https://github.com/valora-inc/wallet/blob/main/src/transactions/feed/queryHelper.ts). ### Test plan Eveything works as before. ### Related issues - Relates to RET-1207 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Reverts #6101 as the GraphQL endpoint for Alfajores has been fixed. Context: https://valora-app.slack.com/archives/C01AEKH9XGX/p1728460043801219?thread_ts=1727801385.833739&cid=C01AEKH9XGX CI succeeds NA NA NA
(#6160) Co-authored-by: Anka <[email protected]>
#6159) ### Description https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Stablecoin-Enablement?node-id=7514-85993&node-type=instance&m=dev https://linear.app/valora/issue/ACT-1406/daily-rate * Daily yield rate in pool info screen when available * small style fix to learn more link #### Daily Yield Rate https://github.com/user-attachments/assets/9ad04f6c-a06c-4e49-9af5-a9d8c6a2d1f7 #### Link Style https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Stablecoin-Enablement?node-id=7514-85993&node-type=instance&m=dev | Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/1a9e19cd-48c2-4eb9-ba67-23a864232343" width="250px"> | <img src="https://github.com/user-attachments/assets/05afb6d8-59c3-4786-b4f7-368828b1f667" width="250px"> | ### Test plan Unit tests and manually verified ### Related issues https://linear.app/valora/issue/ACT-1406/daily-rate
Co-authored-by: Valora Bot <[email protected]>
### Description Part 1 of adding safety score section, showing details / bottom sheet will be in a follow up ### Test plan unit tests, manually by opening beefy pool <img src="https://github.com/user-attachments/assets/a9bd00c5-737d-42f8-94a0-7d3266ce8f84" width="250" /> ### Related issues - Part of ACT-1405 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
…ata is empty (#6152) ### Description 6th PR for RET-1207. Adds handling of the empty transaction feed. There is a possibility that a new user can have a few pending/failed transactions that are stored in `standByTransactions` but paginated data returning empty array for the first page. In this case we need to show stand by transactions. ### Test plan Adds test to show stand by transactions if the paginated data is empty. ### Related issues - Relates to RET-1207 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
### Description 7th PR for RET-1207. Add "No more transactions" toast when: - the first page is the only page and there's decent amount of transactions to trigger the scroll - next page returns an empty array This behaviour will be changed in the follow-up PR once connected to the new blockchain-api handler. ### Test plan Adds tests to check the new toast behaviour. ### Related issues - Relates to RET-1207 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Related issues
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: