Pass additional start arguments with environment variable #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case you'd like to configure the start arguments of `valkey-server` with environment variable, you can pass them with `VALKEY_EXTRA_FLAGS` without having to overwrite the CMD: ```console $ docker run --env VALKEY_EXTRA_FLAGS='--save 60 1 --loglevel warning' valkey/valkey ``` resolves valkey-io#18 Signed-off-by: Ali Ismayilov <[email protected]>
aliismayilov
force-pushed
the
env-extra-flags
branch
from
770e41b
to
49e7a04
Compare
roshkhatri
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows configuration of the start arguments of
valkey-serverwithout having to overwrite theCMD. An example of passing arguments viaVALKEY_EXTRA_FLAGSwould look like this:$ docker run --env VALKEY_EXTRA_FLAGS='--save 60 1 --loglevel warning' valkey/valkeyresolves #18