Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use setpriv instead of gosu #24

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

jrwren
Copy link
Contributor

@jrwren jrwren commented Jun 6, 2024

No description provided.

@jrwren
Copy link
Contributor Author

jrwren commented Jun 6, 2024

for #22

This is the minimal PR which didn't run apply.sh. Please comment if you'd prefer that I run it to update the dockerfiles.

@roshkhatri
Copy link
Member

Yes, we would prefer to update the Docker files so we can build the images.

@roshkhatri
Copy link
Member

Please sign off the commits, wouldn't be able to merge without it

@jrwren jrwren force-pushed the 002-del-gosu-use-setpriv branch 2 times, most recently from 9d720aa to 0f51f98 Compare June 6, 2024 23:04
Signed-off-by: Jay R. Wren <[email protected]>
@jrwren
Copy link
Contributor Author

jrwren commented Jun 7, 2024

I did not really understand this signoff thing so I squashed the commits to do it. Please take another look.

@roshkhatri roshkhatri self-requested a review June 10, 2024 16:44
Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seems good and the image build successfully.

@roshkhatri roshkhatri requested a review from madolson June 10, 2024 16:45
@roshkhatri roshkhatri merged commit e8c75a0 into valkey-io:mainline Aug 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants