common automatic update #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Aug 1, 2023
mbaldessari
commented
- Upgrade vault-helm to v0.25.0
- Error out from load-iib when INDEX_IMAGES is undefined
- Fix up tests after common rebase
If you call the load-iib target you *must* set INDEX_IMAGES, so
let's error out properly if you do not.
Tested as:
$ unset INDEX_IMAGES
$ make load-iib
make -f common/Makefile load-iib
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
No INDEX_IMAGES defined. Bailing out
$ export INDEX_IMAGES=foo
make load-iib
make -f common/Makefile load-iib
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
PLAY [IIB CI playbook] ***
Error out from load-iib when INDEX_IMAGES is undefined
…0.25.0 Upgrade vault-helm to v0.25.0
waynedovey
pushed a commit
to waynedovey/multicloud-gitops
that referenced
this pull request
Sep 8, 2023
Use more recent python versions to unreak CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.