common automatic update #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Jul 14, 2023
mbaldessari
commented
- Split off global helm variables to a helper definition
- Switch ApplicationSets to use the newly-introduced helpers
- Split off valueFiles to _helpers.tbl
- Switch applicationsets to use the new helper
- Drop some older comments
- Tweak the load secret debug message to be clearer
- Include an example SNO cluster pool in the tests
- Enforce lowercase names for cluster claims
- Avoid mixing yaml and json in the OCP install-config
- Update provisioning tests
- Fix up common/ tests
We can only split out bits of yaml that reference $.* variables. This is because these sinppets in _helpers.tbl are passed a single context either $ or . and cannot use both like the top-level domain.
I only remove the variables that are defined identically in ApplicationSet and in the helper. Leaving the other ones as is as their presence is not entirely clear to me and I do not want to risk breaking things.
When HOME is set we replace it with '~' in this debug message
because when run from inside the container the HOME is /pattern-home
which is confusing for users. Printing out '~' when at the start of
the string is less confusing.
Before:
ok: [localhost] => {
"msg": "/home/michele/.config/hybrid-cloud-patterns/values-secret-multicloud-gitops.yaml"
}
After:
ok: [localhost] => {
"msg": "~/.config/hybrid-cloud-patterns/values-secret-multicloud-gitops.yaml"
}
Tweak the load secret debug message to be clearer
Provision sno
mhjacks
pushed a commit
to mhjacks/multicloud-gitops
that referenced
this pull request
Jul 27, 2023
Print which files we are using to parse values secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.