Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correção do drm/drm_fourcc.h não encontrado #475

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Correção do drm/drm_fourcc.h não encontrado #475

merged 5 commits into from
Jun 2, 2024

Conversation

mxnt10
Copy link
Contributor

@mxnt10 mxnt10 commented May 25, 2024

Correção para a discussão dessa issue #471

Resolvi contribuir com esse ajuste.

Testado e funcionando Slackware e Ubuntu.

@valbok
Copy link
Owner

valbok commented May 29, 2024

Thanks for contribution.


#ifdef USE_LIBDRM
#include <libdrm/drm_fourcc.h>
#else
#include <drm/drm_fourcc.h>
Copy link
Owner

@valbok valbok May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

val@qt:~$ dpkg -S /usr/include/drm/drm_fourcc.h
linux-libc-dev:amd64: /usr/include/drm/drm_fourcc.h
val@qt:~$ dpkg -S /usr/include/libdrm/drm_fourcc.h
libdrm-dev:amd64: /usr/include/libdrm/drm_fourcc.h

Looks it is too different packages, so I would suggest to use
#include <drm_fourcc.h>
but in cmake/pro file to add include path to found package, instead of inventing the define.

$ pkg-config --cflags libdrm
-I/usr/include/libdrm

How you like this idea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que eu entendi. Nós temos:
drm/drm_fourcc.h
libdrm/drm_fourcc.h

você quer que o compilador escolha entre libdrm ou drm no arquivo cmake/pro.
mas aí teria que mudar para #include <drm_fourcc.h>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes only this should be used,

#include <drm_fourcc.h>

You can try to make it for cmake, will try to think how to adjust qmake pro.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@valbok
Copy link
Owner

valbok commented May 31, 2024

btw
/usr/include/drm/drm_fourcc.h don't you have this on your env? maybe it is better to install it?

dpkg-query -S /usr/include/drm/drm_fourcc.h
linux-libc-dev:amd64: /usr/include/drm/drm_fourcc.h

@valbok valbok merged commit 81e606a into valbok:master Jun 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants