Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DND: 3 new features #2689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DND: 3 new features #2689

wants to merge 2 commits into from

Conversation

rajniszp
Copy link
Contributor

@rajniszp rajniszp commented Jan 16, 2023 •
edited
Loading

This PR introduces 3 new features for DND, all configurable via parameter:

  • drag_all_nodes: controls whether all nodes are dragged instead of only top level selected nodes (ignoring children of selected nodes)
  • preserve_nodes_order: controls whether nodes that are dragged should be kept in the original order from origin tree (when true) or in order of selecting (when false)
  • disabled: a boolean indicating if dnd should be enabled or not, useful if you want to dynamically disable/enable editing of the tree

If left not specified, default values are used that do not change anything compared to before commit (non breaking change).

@vakata vakata added the v3 label Jan 16, 2023
@rajniszp
Copy link
Contributor Author

Any update? :D

@ArunPatal
Copy link

This change look useful to me 👍

@rajniszp
Copy link
Contributor Author

Hi, just reminding of this PR

@rajniszp
Merge pull request #1 from vakata/master
57d60b2 
Merge from vakata/jstree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajniszp @ArunPatal @vakata