Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): add condition for stateless feature #267

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix(CI): add condition for stateless feature #267

merged 2 commits into from
Sep 11, 2024

Conversation

seemenkina
Copy link
Contributor

rln-cli is based on tree, so I remove this member from stateless build

Copy link

github-actions bot commented Sep 9, 2024

Benchmark for c66baa5

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 878.4±9.94ns 870.4±43.90ns -0.91%
FullMerkleTree::get 3.5±0.06ns 3.4±0.04ns -2.86%
FullMerkleTree::get_empty_leaves_indices 7.5±0.49ns 7.5±0.28ns 0.00%
FullMerkleTree::get_subtree_root 3.7±0.08ns 3.7±0.13ns 0.00%
FullMerkleTree::override_range 1341.6±55.26ns 1350.4±11.42ns +0.66%
FullMerkleTree::set 890.3±99.77ns 876.2±9.06ns -1.58%
OptimalMerkleTree::compute_root 1018.7±12.93ns 1013.6±14.01ns -0.50%
OptimalMerkleTree::delete 1022.2±13.28ns 1021.0±47.26ns -0.12%
OptimalMerkleTree::get 23.4±0.35ns 23.2±2.15ns -0.85%
OptimalMerkleTree::get_empty_leaves_indices 7.1±0.06ns 7.1±0.12ns 0.00%
OptimalMerkleTree::get_subtree_root 23.4±0.19ns 24.1±0.29ns +2.99%
OptimalMerkleTree::override_range 4.1±0.06µs 4.2±0.13µs +2.44%
OptimalMerkleTree::set 1018.6±13.60ns 1006.1±14.07ns -1.23%

Copy link

github-actions bot commented Sep 9, 2024

Benchmark for c66baa5

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 15.0±0.12ms 15.1±0.04ms +0.67%
OptimalMerkleTree::::full_height_gen 574.5±4.46µs 578.6±15.61µs +0.71%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 339.9±4.27ns 324.3±4.32ns -4.59%
Pmtree::get_empty_leaves_indices 8.4±0.08ns 8.4±0.13ns 0.00%
Pmtree::get_subtree_root 518.1±7.53ns 478.2±9.18ns -7.70%
Pmtree::override_range 230.9±3.45µs 231.2±3.27µs +0.13%
Pmtree::set 54.2±0.53µs 54.0±0.49µs -0.37%
Pmtree:delete 53.9±0.63µs 54.4±0.42µs +0.93%
Set/FullMerkleTree::::set/1 556.3±4.29µs 555.2±3.48µs -0.20%
Set/FullMerkleTree::::set/10 5.6±0.00ms 5.6±0.02ms 0.00%
Set/FullMerkleTree::::set/100 55.3±0.13ms 55.7±0.17ms +0.72%
Set/FullMerkleTree::::set_range/1 555.9±3.20µs 556.0±3.53µs +0.02%
Set/FullMerkleTree::::set_range/10 752.8±5.60µs 755.6±3.47µs +0.37%
Set/FullMerkleTree::::set_range/100 3.2±0.01ms 3.3±0.01ms +3.13%
Set/OptimalMerkleTree::::set/1 573.5±26.65µs 560.1±5.49µs -2.34%
Set/OptimalMerkleTree::::set/10 5.7±0.02ms 5.6±0.02ms -1.75%
Set/OptimalMerkleTree::::set/100 57.4±0.20ms 55.8±0.60ms -2.79%
Set/OptimalMerkleTree::::set_range/1 567.5±2.96µs 560.3±5.91µs -1.27%
Set/OptimalMerkleTree::::set_range/10 5.7±0.12ms 5.6±0.02ms -1.75%
Set/OptimalMerkleTree::::set_range/100 57.5±0.08ms 55.9±0.10ms -2.78%
vk::vk_from_ark_serialized 1576.2±7.00ns 1582.0±18.05ns +0.37%
zkey::zkey_from_raw 3.4±0.00s 3.4±0.00s 0.00%

Copy link

github-actions bot commented Sep 9, 2024

Benchmark for 045d740

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 863.6±23.07ns 870.4±7.94ns +0.79%
FullMerkleTree::get 3.4±0.06ns 3.4±0.07ns 0.00%
FullMerkleTree::get_empty_leaves_indices 7.9±1.58ns 7.5±0.27ns -5.06%
FullMerkleTree::get_subtree_root 3.6±0.18ns 3.5±0.12ns -2.78%
FullMerkleTree::override_range 1375.1±38.81ns 1375.3±21.61ns +0.01%
FullMerkleTree::set 865.6±12.71ns 865.3±12.23ns -0.03%
OptimalMerkleTree::compute_root 1014.5±15.46ns 1029.2±15.94ns +1.45%
OptimalMerkleTree::delete 1016.7±13.99ns 1037.5±39.14ns +2.05%
OptimalMerkleTree::get 22.7±0.70ns 22.7±1.01ns 0.00%
OptimalMerkleTree::get_empty_leaves_indices 7.1±0.12ns 7.1±0.12ns 0.00%
OptimalMerkleTree::get_subtree_root 24.0±0.41ns 24.6±2.12ns +2.50%
OptimalMerkleTree::override_range 4.3±0.02µs 4.3±0.18µs 0.00%
OptimalMerkleTree::set 1007.7±6.05ns 1045.2±53.71ns +3.72%

Copy link

github-actions bot commented Sep 9, 2024

Benchmark for 045d740

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.7±0.14ms 15.5±0.13ms +5.44%
OptimalMerkleTree::::full_height_gen 582.7±2.83µs 581.3±6.12µs -0.24%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 323.1±2.33ns 325.0±4.42ns +0.59%
Pmtree::get_empty_leaves_indices 8.4±0.10ns 8.4±0.12ns 0.00%
Pmtree::get_subtree_root 478.1±5.11ns 477.9±12.87ns -0.04%
Pmtree::override_range 246.8±5.47µs 239.6±6.77µs -2.92%
Pmtree::set 54.1±0.38µs 54.3±0.65µs +0.37%
Pmtree:delete 54.0±0.78µs 53.9±0.52µs -0.19%
Set/FullMerkleTree::::set/1 552.6±4.16µs 556.0±4.28µs +0.62%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.5±0.04ms -1.79%
Set/FullMerkleTree::::set/100 55.3±0.10ms 55.3±0.15ms 0.00%
Set/FullMerkleTree::::set_range/1 554.4±6.98µs 554.3±3.98µs -0.02%
Set/FullMerkleTree::::set_range/10 753.0±5.84µs 754.7±3.84µs +0.23%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.11ms 0.00%
Set/OptimalMerkleTree::::set/1 564.0±47.88µs 554.8±2.81µs -1.63%
Set/OptimalMerkleTree::::set/10 5.6±0.01ms 5.6±0.04ms 0.00%
Set/OptimalMerkleTree::::set/100 55.5±0.14ms 55.6±0.10ms +0.18%
Set/OptimalMerkleTree::::set_range/1 555.5±6.63µs 554.3±4.19µs -0.22%
Set/OptimalMerkleTree::::set_range/10 5.6±0.05ms 5.5±0.02ms -1.79%
Set/OptimalMerkleTree::::set_range/100 55.8±1.91ms 55.4±0.36ms -0.72%
vk::vk_from_ark_serialized 1609.1±26.97ns 1603.0±10.42ns -0.38%
zkey::zkey_from_raw 3.4±0.00s 3.4±0.01s 0.00%

@seemenkina seemenkina merged commit fc823e7 into master Sep 11, 2024
10 checks passed
@seemenkina seemenkina deleted the fix-ci branch September 11, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants