Fix Files for Linting #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimstir
force-pushed
the
workflowNewA
branch
from
e673d96
to
1b7a998
Compare
Closed
felicio
reviewed
Sep 12, 2024
status/raw/simple-scaling.md
Outdated
There was a problem hiding this comment.
In References
Suggested change
| * [55/STATUS-1TO1-CHAT](../55/1to1-chat.md) |
There was a problem hiding this comment.
478:3-478:45 warning Link to unknown file: `.../55/1to1-chat.md`. Did you mean `../55/1to1-chat.md` missing-file remark-validate-links
felicio
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Suggested change
| The type parallels the `timestamp` of [WakuMessage](../../waku/standards/core/14/message.md). |
There was a problem hiding this comment.
132:39-132:103 warning Link to unknown file: `../../waku/standards/core/14/message.md/#payloads`. Did you mean `../../waku/standards/core/14/message.md` missing-file remark-validate-links```
felicio
reviewed
Sep 12, 2024
| /{application-name}/{version-of-the-application}/{content-topic-name}/{encoding} | ||
| ``` | ||
|
|
||
| All messages sent with this topic MUST be instances of `ApplicationMetadataMessage` ([62/STATUS-PAYLOAD](../62/payload.md)) with a `payload` of `CommunityMessageArchiveIndex`. | ||
| All messages sent with this topic MUST be instances of `ApplicationMetadataMessage` | ||
| ([62/STATUS-PAYLOAD](../62/payload.md)) with a `payload` of `CommunityMessageArchiveIndex`. |
There was a problem hiding this comment.
Suggested change
| ([62/STATUS-PAYLOAD](../62/payload.md)) with a `payload` of `CommunityMessageArchiveIndex`. | |
| ([62/STATUS-PAYLOAD](../62/payloads.md)) with a `payload` of `CommunityMessageArchiveIndex`. |
There was a problem hiding this comment.
292:86-292:123 warning Link to unknown file: `../62/payload.md`. Did you mean `../62/payloads.md` missing-file remark-validate-links
felicio
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Missing description in Frontmatter.
There was a problem hiding this comment.
@felicio I missed this one, I will add this in a separate pr and add you as reviewer. Also, for the other markdown rules that should be added, after discussion.
felicio
reviewed
Sep 12, 2024
status/62/payloads.md
Outdated
| The status client therefore makes a "bid", | ||
| speculating that it will beat the current chat-timestamp, | ||
| s.t. the status client's Lamport timestamp format is: | ||
| `clock =`max({timestamp}, chat_clock + 1)` |
There was a problem hiding this comment.
Suggested change
| `clock =`max({timestamp}, chat_clock + 1)` | |
| `clock = max({timestamp}, chat_clock + 1)` |
|
Needed to push a hotfix branch in https://github.com/vacp2p/rfc-index/commits/0b4d15163850762de0c62445ac093bfd2315a076-hotfix/ before this one is resolved. |
felicio
reviewed
Sep 12, 2024
status/raw/simple-scaling.md
Outdated
There was a problem hiding this comment.
Suggested change
| * [23/WAKU2-TOPICS](../../waku/informational/23/topics.md) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all files in the repo adhere to the markdown linting rules.