fix(yamux): future leak #1171
Merged
fix(yamux): future leak #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
========================================
Coverage 84.53% 84.54%
========================================
Files 91 92 +1
Lines 15517 16424 +907
========================================
+ Hits 13118 13885 +767
- Misses 2399 2539 +140
|
| await closedRemotelyFut.cancelAndWait() | ||
| if not receivedDataFut.finished(): | ||
| await receivedDataFut.cancelAndWait() | ||
| await closedRemotelyFut or receivedDataFut |
There was a problem hiding this comment.
It is probably better to use
proc raceCancel*(
futs: seq[InternalRaisesFuture]
): Future[FutureBase] {.async: (raises: [ValueError, CancelledError]).} =
try:
discard await race(futs)
finally:
await noCancel allFutures(futs.filterIt(not it.finished).mapIt(it.cancelAndWait))There was a problem hiding this comment.
It's also going to handle cancelations.
There was a problem hiding this comment.
I'm not a huge fan of using InternalRaisesFuture outside of Chronos tbh.
There was a problem hiding this comment.
Me neither, but that's the only way for now, unless SomeFuture is changed to public.
diegomrsantos
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first glance, this fixes #1165.
It raises another issue: I always thought that Future unfinished caught in the GC were cancelled. But that doesn't always seem to be the case.