forked from vacp2p/nim-libp2p
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torpush #1
Draft
ujscale
wants to merge
2
commits into
unstable
Choose a base branch
from
torpush
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiserd
reviewed
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments after looking at the code briefly.
@Menduist agreed to give more feedback next week 🙏
Adding this feature shouldn't require any modification to nim-libp2p (I think). What you need to do is:
Once everything is setup, it should be a matter of:
|
Thanks for the suggestions and comments. Looking into and adjusting the
approach.
…On Mon, Jul 24, 2023 at 2:26 PM Tanguy ***@***.***> wrote:
Adding this feature shouldn't require any modification to nim-libp2p (I
think).
What you need to do is:
- Create a torSwitch in nimbus, here for instance
https://github.com/status-im/nimbus-eth2/blob/60f0a2f6a662abb9c8332d9f0d3eb7cc998fab63/beacon_chain/networking/eth2_network.nim#L60
- Also create a second GossipSub structure, and mount it to the
TorSwitch
- Also mount any mandatory eth2 protocols to this switch (probably
get_metadata, maybe others)
Once everything is setup, it should be a matter of:
- Connect to few random peers on the torSwitch
- For every message publication
<https://github.com/status-im/nimbus-eth2/blob/60f0a2f6a662abb9c8332d9f0d3eb7cc998fab63/beacon_chain/networking/eth2_network.nim#L2511>,
use the torGossipSub instead of the regular one
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAOUQ3I3RKDSMY4YYZWJAXDXRY5TTANCNFSM6AAAAAA2SYVVVA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic test for torpush format with encode/decode